fix(ci): restore validate-model-carry-boundary in make validate - #23
Merged
Conversation
The portable-ai-carry-packs merge (5acdceb) dropped the `validate-model-carry-boundary` target and its prerequisite from the `validate` target, so CI (validate.yml) stopped running tools/validate_model_carry_authorization_boundaries.py — the validator and its schema/examples still existed and passed, but nothing invoked them (declared-unenforced). Restore the target, its .PHONY entry, and the `validate` prerequisite. Note: the same merge also dropped `bin/$(BIN) validate --refs examples` and `bin/$(BIN) list --refs examples`. Those are NOT restored verbatim — the CLI was restructured between 48904d4 and main and no longer has top-level `validate`/`list` subcommands (they moved under `carry`). `carry validate` was already in the recipe; the old `list --refs` coverage is restored as its current equivalent `carry list --refs`. `make validate` passes green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore the
validate-model-carry-boundarytarget dropped by the portable-ai-carry-packs merge (5acdceb), and re-add it to thevalidatetarget's prerequisites +.PHONY.Why
tools/validate_model_carry_authorization_boundaries.pyand its schema/examples still exist and pass, but5acdcebremoved the Makefile target and its prereq, somake validate— and therefore CI (.github/workflows/validate.yml) — stopped invoking it. A validator that exists and passes but is never run is declared-unenforced.Deviation from a literal revert (important)
The same merge also removed
bin/$(BIN) validate --refs examplesandbin/$(BIN) list --refs examples. These are not restored verbatim: the CLI was restructured between48904d4andmainand no longer exposes top-levelvalidate/list(they now live undercarry). Restoring them literally makesmake validatefail withError 2(verified). So:carry validate --refs exampleswas already present (the replacement for the old top-levelvalidate).list --refscoverage is restored as its current equivalentcarry list --refs examples.Verification
make validateruns green end-to-end (exit 0), and the boundary validator is confirmed to actually execute in the chain.