Fix delegation problem due to removed wavestack#1251
Merged
Conversation
Amending a13247b Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
gerbsen
approved these changes
Jul 20, 2026
gerbsen
left a comment
gerbsen
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but in my opinion, it shouldn't be the case that an incorrect entry affects the test results of the other entries. I'll open an issue for this.
Contributor
Author
The HTTP request has to report failure, and it shouldn't succeed "half way" (partially). It's an atomic operation. However, we shouldn't send all reports with one HTTP request. We should expend one request per report. This is probably going to be addressed with a major overhaul that's currently in development anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amending a13247b