Add decimal broadcast dispatch and scale-aware print formatting - #184
Merged
Conversation
Broadcast: add Decimal32/64/128 arms to broadcast_length_1_array so a length-1 DecimalArray repeats to the target length, preserving precision, scale, and null mask. Scalar::Decimal variants already convert to single-element arrays (TSK377), so the end-to-end scalar broadcast path now works through the existing maybe_broadcast_scalar_array infrastructure. Print: fix value_to_string to format individual decimal values at the requested index using format_decimal_value, instead of formatting the entire DecimalArray. Positive scale inserts a decimal point, zero scale returns the raw integer, negative scale appends trailing zeros, and null values display as "null".
pbower
changed the title
pbower
added a commit
that referenced
this pull request
Aug 31, 2026
* Add DecimalArray foundation and i128 trait impls (#181) * Add Decimal32, Decimal64, Decimal128 variants to ArrowType (#180) * Wire DecimalArray into NumericArray, Array, Scalar with From impls (#182) * Wire DecimalArray into NumericArray, Array, and Scalar enums with From impls and tests (#182) * Implement decimal conversion arms in NumericArray try_ accessors * Add decimal FFI import/export with arrow-rs and Polars round-trips (#186) * Add decimal FFI import/export with arrow-rs and Polars round-trips * Integrate DecimalArray into Value, ArrayV, NumericArrayV, SuperArray, SuperArrayV, and Consolidate (#187) * Add decimal broadcast dispatch and scale-aware print formatting (#184) * Add decimal arithmetic kernels with checked overflow and auto-promotion + fix null mask drop on broadcasting (#185) * Add decimal arithmetic kernels with checked overflow and auto-promotion * Propagate null mask through broadcast for all array types * Add DecimalArray type conversions and width conversion methods (#183) * Add decimal support to pyo3 and minarrow-py Python bridges (#188) * Add Decimal32 and Decimal64 round-trip tests for arrow-rs * Add decimal support to pyo3 and minarrow-py Python bridges * Make precision and scale report values for all numeric types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
broadcast_length_1_arrayfor repeating length-1 decimal arrays to target length, preserving precision/scale and null maskvalue_to_stringfor decimal variants to use per-element scale-aware formatting instead of formatting the entire arrayTest plan
cargo test --features "decimal,chunked,views"passes (786 tests)cargo testwithout decimal passes (no regression)