fix: allowlist salvage_wreck and sell_ship in api-sync drift check - #27
fix: allowlist salvage_wreck and sell_ship in api-sync drift check#27statico-alt wants to merge 1 commit into
Conversation
Both commands exist server-side (POST returns 401, not 404) but are absent from openapi.json, so the api-sync drift check failed on main. Add them to UNDOCUMENTED_IN_SPEC, matching the test's documented remedy.
|
Superseded by #28 — recommend closing this one. Two problems with the approach here:
#28 drops the two dead commands, adds the missing endpoints, and is green. #26 (the gh#1874 wreck-render fix) is blocked behind whichever of these lands. |
|
Superseding this with #28, which has now merged. The premise here was wrong: Allowlisting them would have kept the client advertising two dead commands to players. #28 removes them instead and fixes the underlying drift check. Closing. |
Summary
The api-sync drift check was failing on
main:salvage_wreckandsell_shipare present in the client'sCOMMANDSblock but missing from the liveopenapi.json, so the test flagged them as stale.Both commands still exist server-side — a
POSTto each returns401(auth required), not404— they're simply undocumented in the OpenAPI spec. Added them toUNDOCUMENTED_IN_SPEC, which is exactly the remedy the test documents for this case. No client behavior change.Player-Facing Release Notes