sync+compliance(§4.3): invert LICENSE symlink direction — v1.38 - #18
Conversation
Back-sync of Spacecraft-Software/Standard#17, plus the self-apply. GitHub's license detector reads git blobs, and a symlink's blob is the target path rather than the license text — so the v1.36 layout left this repo reporting NOASSERTION. §4.3 is inverted: the root LICENSE is a regular file holding the verbatim primary license text, and LICENSES/<SPDX-id>.txt for that license symlinks back to it. reuse follows the link through the filesystem and lints clean; GitHub gets a real blob. The text still exists exactly once. Self-apply: LICENSE now carries the canonical FSF GPL-3.0 text (the same text sibling repos ship, which GitHub detects as GPL-3.0), replacing the reflowed REUSE-shipped variant; LICENSES/GPL-3.0-or-later.txt symlinks to it. Apache-2.0, GFDL-1.3-or-later, and MIT stay regular files — they are secondary licenses (§4.2), not the repo's primary. SKILL.md §4.3 body, §5.2 LICENSE row, §16 checklist bullet, masthead, and frontmatter description synced; references/CHANGELOG.md entry added; both bundles rebuilt in the same commit. Frontmatter description: 935 chars (under the 1000-char limit). reuse lint: compliant, 604/604 files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccb09ef9ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # The Steelbore Standard — Compliance Reference | ||
|
|
||
| **Version:** 1.37 | **Date:** 2026-07-26 | **Author:** Mohamed Hammad | ||
| **Version:** 1.38 | **Date:** 2026-07-26 | **Author:** Mohamed Hammad |
There was a problem hiding this comment.
Sign the commit and add the assistant attribution trailer
The reviewed commit object has no gpgsig header (git verify-commit e599e12bc91050f01d9866aa4f37350956832847 exits with status 1), and its assistant-generated message lacks the required Co-Authored-By: Claude … trailer. Recreate the proposed commit with configured signing and the attribution trailer before merging so its provenance satisfies the repository requirements.
AGENTS.md reference: AGENTS.md:L25-L26
Useful? React with 👍 / 👎.
| ```sh | ||
| ln -s LICENSES/GPL-3.0-or-later.txt LICENSE | ||
| git add LICENSE | ||
| cp <canonical license text> LICENSE |
There was a problem hiding this comment.
Replace the non-runnable license copy placeholder
When an agent follows this fenced sh recipe literally, the shell parses <canonical and text> as input/output redirections and executes cp license text, rather than copying a canonical license into LICENSE; if a file named canonical exists, it can also truncate the existing LICENSE. Use a concrete one-argument source-path placeholder or an explicit download command so the authoritative migration procedure is safe to execute.
Useful? React with 👍 / 👎.
| `LICENSE` is a **regular file** carrying the verbatim text of the project's primary | ||
| license, and `LICENSES/<SPDX-id>.txt` for that same license is a **symbolic link** | ||
| to it. Every project MUST ship both. |
There was a problem hiding this comment.
Correct the Grok README after reversing the symlink
This new layout makes the existing license text in grok-skills/README.md:93-94 false: it still says the root LICENSE is a symlink to LICENSES/GPL-3.0-or-later.txt, while this commit makes the root file regular and the LICENSES/ entry the symlink. Update that consumer-facing documentation in the same change so the repository does not publish mutually contradictory §4.3 instructions.
Useful? React with 👍 / 👎.
Back-sync of Spacecraft-Software/Standard#17, plus the self-apply. Same version (1.38), same date (2026-07-26).
Why
GitHub's license detector reads git blobs; a symlink's blob is the target path, not the license text. The v1.36 layout left this repo reporting
NOASSERTION— no identified license — where sibling repos with a regularLICENSEreportGPL-3.0.Change
LICENSEis now a regular file with the canonical FSF GPL-3.0 text (byte-identical to whatanvil/bravais/pearliteship, which GitHub detects), replacing the reflowed REUSE-shipped variant.LICENSES/GPL-3.0-or-later.txtsymlinks to it.Apache-2.0,GFDL-1.3-or-later, andMITstay regular files — they are secondary licenses (§4.2), not this repo's primary.SKILL.md— §4.3 body rewritten, §5.2LICENSErow and §16 checklist bullet updated, masthead and frontmatter bumped to v1.38.references/CHANGELOG.md— v1.38 entry.Verification
reuse lint→ compliant, 604/604 files (it follows the symlink through the filesystem)description→ 935 characters (under the 1000-char working limit)unzip -l→ bundles carry the currentSKILL.md+references/CHANGELOG.md🤖 Generated with Claude Code