fix(standard): Skill Cross-References named a skill that does not exist — v1.44 - #23
Merged
Merged
Conversation
…st — v1.44 The accessibility row pointed at `spacecraft-accessibility`. The skill has been `spacecraft-accessibility-support` since it was added. An agent following the Standard to find the §18 implementation layer would have looked for a directory that is not there, and the failure is silent: a missing skill does not announce itself, it simply never loads, so §18 work would proceed without the reference the Standard directs it to. spacecraft-standard-constitution's own cross-reference table has carried the correct name throughout, so the two documents disagreed and the published one was wrong. A cross-reference is normative content like any other clause, and renaming a skill is a two-repo edit. Every other skill name cited in the document was verified against the catalogue in the same pass; this was the only bad one. No rules change and no section text was touched. makeinfo --no-split: zero errors, zero warnings. reuse lint passes. .md companion regenerated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
UnbreakableMJ
added a commit
to Spacecraft-Software/Construct
that referenced
this pull request
Aug 5, 2026
…andard (#29) An audit of all 45 first-party skills across nine drift classes turned up four real findings. Three were contradictions or rot; one was a coverage gap. 1. §13 contradiction — spacecraft-brand-guidelines said "Apply the palette to Material Design components (the required UI system for Spacecraft Software GUIs)". True until v1.42, and directly wrong since: Material covers Flutter, web, mobile, and cross-platform; GTK 4 takes GNOME HIG and Qt 6 takes KDE HIG. Rewritten to name all three and to say plainly that the palette is system-agnostic — §13 chooses the widget vocabulary, §11 supplies the colors. spacecraft-accessibility-support/references/gui.md carried a milder version of the same assumption and now generalizes the same way, which matters there because that file documents the GTK and Qt bridges a few lines above. 2. Version-pin rot — brand-guidelines pinned v1.39, theme-factory and steelbore-color-palette v1.42. Two of the three were written today and were already stale one release later, which is the tell: the phrasing is the defect, not the numbers. "Source of truth: The Steelbore Standard v1.42 (§11, §12)" is ambiguous between document version and clause version and rots on every unrelated release. All three now cite sections rather than a document version. steelbore-color-palette keeps "§11 — last amended in v1.39", which is accurate and stable because it moves only when §11 moves; §12's last real amendment could not be established (v1.16 predates the v1.24 renumbering), so nothing is asserted about it. 3. Flutter accessibility gap — spacecraft-flutterdart-guidelines had zero mentions of §18, Semantics, or a screen reader anywhere in the skill, while §18.3 names Semantics/SemanticsRole as its required bridge and §18 makes an accessible mode mandatory for every non-game application. The GTK and Qt skills carry this; Flutter did not. Added: a Core Philosophy clause, an abstraction-choice row, three Required Techniques, a CI gate, five anti-patterns, six checklist items, a cross-reference to spacecraft-accessibility-support, and reference §6 with runnable Semantics, SemanticsService.announce, CustomPainter.semanticsBuilder, and meetsGuideline test patterns. Reference sections renumbered 6→7, 7→8. 4. Constitution synced to Standard v1.44 (Spacecraft-Software/Standard#23), which fixes the published cross-reference table naming a skill that does not exist — spacecraft-accessibility rather than spacecraft-accessibility-support. This skill's table was already correct, so only the version moves here. Clean on audit: retired §11.2 tokens (all legitimate Steelbore Classic), §4.3 LICENSE symlink direction, §14.2 date offsets, §3.1.1 TypeScript, §12 fonts, §6.4 outbound publication, every other skill-name reference, and the §16 checklists (26 items, matching ids). Six skills' bundles rebuilt. Description cap, reuse lint, and the full drift sweep pass. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
UnbreakableMJ
added a commit
that referenced
this pull request
Aug 5, 2026
This document cites skills by id, but the catalogue lives in Construct, so nothing here could tell whether a cited skill exists. It shipped for months naming `spacecraft-accessibility` when the skill had always been `spacecraft-accessibility-support` (fixed in v1.44, #23) — silently, because a missing skill does not announce itself; it simply never loads, and §18 work directed at it proceeds without it. The new `skill-refs` job checks out Construct read-only — both repos are public, so no token and `persist-credentials: false` — and runs Construct's `.github/check-skill-refs.py` against the .texi and its .md companion. The dependency direction is deliberate: this document cites the catalogue, so this document validates against it. One implementation serves both repos rather than a copy drifting on each side, which is the same failure this job exists to prevent. `--no-version-check` is passed: the checker's second rule bans Standard document-version pins in skills, but this document's own masthead version is the one legitimate pin in the ecosystem. Companion to Spacecraft-Software/Construct#30, which adds the script and wires the same checks over the catalogue itself. That PR is merged, so the script is on Construct's main and this job can find it. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Skill Cross-References table pointed at
spacecraft-accessibility. The skill has beenspacecraft-accessibility-supportsince it was added.An agent following the Standard to find the §18 implementation layer would look for a directory that is not there — and the failure is silent. A missing skill does not announce itself; it simply never loads. §18 work would proceed without the reference the Standard directs it to.
spacecraft-standard-constitution's own cross-reference table has carried the correct name throughout, so the two documents disagreed and the published one was wrong.Found by an audit of the whole skill catalogue against the Standard. Every other skill name cited in the document was validated against the catalogue in the same pass — this was the only bad one.
Scope
@settitle,@set VERSION→ 1.44CHANGELOG.mdentry;.mdcompanion regeneratedNo rules change and no section text was touched. A cross-reference is normative content like any other clause, and renaming a skill is a two-repo edit.
Verification
makeinfo --no-split→ zero errors, zero warningsreuse lint→ compliant.texire-validated against the catalogue → cleanCompanion PR
Spacecraft-Software/Construct#29 syncs the constitution skill to v1.44 and fixes three further drifts found in the same audit.
🤖 Generated with Claude Code