chore(release): re-cut as 1.0.14 so the add-on sees an update - #38
Merged
Conversation
PRs #36 and #37 both merged carrying version 1.0.13. The add-on image tag is derived from span_panel_simulator/config.yaml, so the second merge rebuilt and overwrote the first's 1.0.13 image without changing the version. Anyone who pulled 1.0.13 between the two merges holds the circuit-energy fix but not the vendored flat emitter, and Supervisor has no version change to prompt on — so the vendoring, including the fix for an add-on image that could never start, would never reach them. Bump all four version references to 1.0.14, relabel the vendoring changelog entry (already the topmost) from 1.0.13 to 1.0.14, and record why in a note under it. The circuit-energy entry keeps 1.0.13, which is the version its image was actually published under. Also refreshes uv.lock, which still recorded 1.0.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#36 and #37 both merged carrying version 1.0.13.
The add-on image tag is derived from
span_panel_simulator/config.yaml(see theExtract version from config.yamlstep inbuild-addon.yaml), and the build workflow fires on every push tomaintouchingsrc/**,pyproject.toml, orspan_panel_simulator/**. So:1.0.13(circuit-energy fix)1.0.13tag (vendoring)Anyone who pulled
1.0.13between the two merges holds the circuit-energy fix but not the vendored flat emitter — and Supervisor has no version change to prompt on, so they never get it. That matters more than usual here, because the vendoring is the fix for an add-on image that could never start.What changed
pyproject.toml,__init__.py,config.yaml,Dockerfile— kept in step by thesync-versionpre-commit hook).1.0.13→1.0.14, with a short note recording why.1.0.13— that is the version its image was actually published under, so the history stays truthful.uv.lockrefreshed; it still recorded1.0.13.Verification
ruff checkclean,mypy --strictclean across 85 source filessync-versionWorth considering separately
The collision was structural, not a slip: two branches cut from the same base each bumped to the next patch version, and nothing rejected the duplicate at merge time. A CI check that fails when
config.yaml's version is not greater than the version onmainwould catch it at PR time rather than after publish. Happy to add that if you want it.