Skip to content

feat: complete all base model enhancement#21

Merged
jeafreezy merged 1 commit intofeat/base-modelsfrom
feat/base-model-contribution
Mar 7, 2026
Merged

feat: complete all base model enhancement#21
jeafreezy merged 1 commit intofeat/base-modelsfrom
feat/base-model-contribution

Conversation

@superwaih
Copy link
Collaborator

this PR solves all the enhancements highlight in

  1. For the details page, those long contents, make it a markdown. Use the best suited markdown library and create an ADR for it. ✅
  2. Make the sidebar sticky on the details page too (Confirm this with Bright). ✅
  3. Let the 'Contribute Model' modal with the instructions support opening multiple accordion at a time. ✅
  4. Also let the 'GO TO GITHUB' open in a new tab. ✅
  5. On the landing page: the text 'Contribute Your Base Model', make the 'Y' capital. ✅
  6. Sync with bright with respect to the mapview and list view. If it's not available remove it. ✅
  7. Fix the mobile filters we spoke about as well. ✅

Before

before-enhancements.mov

After

after-enhancements.mov

@superwaih superwaih requested a review from jeafreezy March 5, 2026 22:53
@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
f-a-ir Ready Ready Preview, Comment Mar 5, 2026 10:54pm

Request Review

@jeafreezy
Copy link

These videos look the same and I can't see the changes.

@jeafreezy
Copy link

I've checked the previewed URL from Vercel, and it looks great. Great job @superwaih !

Can you check this mobile experience ? You can't click on the filters unlesss you move your hand to where the texts are and it shouldn't be the case. It should work if you press anywhere on the filter container.

Screenshot 2026-03-06 at 06 14 07

Copy link

@jeafreezy jeafreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work.

@jeafreezy jeafreezy merged commit 90fd2d2 into feat/base-models Mar 7, 2026
2 checks passed
This was referenced Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants