Skip to content

Modernize docker compose usage & language#4125

Open
neolefty wants to merge 4 commits intoSpeciesFileGroup:developmentfrom
neolefty:compose
Open

Modernize docker compose usage & language#4125
neolefty wants to merge 4 commits intoSpeciesFileGroup:developmentfrom
neolefty:compose

Conversation

@neolefty
Copy link
Contributor

I think the old versions of docker-compose have percolated out of dev environments by now, since v2 was released in 2020. See https://docs.docker.com/compose/releases/migrate

  • docker-compose –> docker compose
  • docker-compose.yml –> compose.yml
  • Remove deprecated "version" tag from compose.yml (it is causing warnings in the dev env)

@mjy
Copy link
Member

mjy commented Dec 3, 2024

@LocoDelAssembly You mentioned a concern with the change in chat I think?

@LocoDelAssembly
Copy link
Contributor

Missed this one. File rename and removing version seems compatible with the docker version that comes with Ubuntu 22.04 LTS (still supported). However I'd remove the unzip mount point as it is not necessary.

The version number was 2 because I think were using something that was removed in later versions, something related to health checks or detecting when the container is ready, but not currently needed since startup script in app container waits for db to come up before letting TW run.

@mjy
Copy link
Member

mjy commented Jan 16, 2025

@neolefty Did you see? V (and comments)?

However I'd remove the unzip mount point as it is not necessary.

@neolefty
Copy link
Contributor Author

@neolefty Did you see? V (and comments)?

However I'd remove the unzip mount point as it is not necessary.

Done! Sorry I forgot about this until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants