Skip to content

fix: add nanoid resolution (BED-9192) - #3121

Merged
dcairnsspecterops merged 1 commit into
mainfrom
nanoid-resolution-fix
Aug 7, 2026
Merged

fix: add nanoid resolution (BED-9192)#3121
dcairnsspecterops merged 1 commit into
mainfrom
nanoid-resolution-fix

Conversation

@dcairnsspecterops

@dcairnsspecterops dcairnsspecterops commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

postcss depends on a vulnerable version of nanoid

postcss released a fix on Wednesday, but it's under quarantine. Seems like we need to add a resolution for now.

Motivation and Context

Resolves BED-9192

Why is this change required? What problem does it solve?

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Database Migrations

Checklist:

@dcairnsspecterops
dcairnsspecterops requested review from a team as code owners August 7, 2026 22:08
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The root package manifest was reformatted and now pins nanoid to ^3.3.17. The doodle-ui package adds the same version to its development dependencies.

Changes

nanoid dependency alignment

Layer / File(s) Summary
nanoid dependency manifest updates
package.json, packages/javascript/doodle-ui/package.json
The root manifest adds a nanoid resolution at ^3.3.17. The doodle-ui manifest adds nanoid at the same version to devDependencies.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: urangel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description identifies the vulnerability and ticket, but it omits detailed motivation, testing results, and completed checklist items. Add the missing motivation and testing details, select only applicable change types, and complete the checklist with accurate status.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: adding a nanoid resolution.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nanoid-resolution-fix

Comment @coderabbitai help to get the list of available commands.

@dcairnsspecterops dcairnsspecterops changed the title fix: add nanoid resolution fix: add nanoid resolution (BED-9192) Aug 7, 2026
@dcairnsspecterops
dcairnsspecterops merged commit ecccc9f into main Aug 7, 2026
17 checks passed
@dcairnsspecterops
dcairnsspecterops deleted the nanoid-resolution-fix branch August 7, 2026 22:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants