Skip to content

fix: prevent large support bundle downloads BED-9186 - #3123

Merged
lrfalslev merged 2 commits into
mainfrom
lfalslev/bed-9186
Aug 10, 2026
Merged

fix: prevent large support bundle downloads BED-9186#3123
lrfalslev merged 2 commits into
mainfrom
lfalslev/bed-9186

Conversation

@lrfalslev

@lrfalslev lrfalslev commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Update openapi schema and trim support bundle for BHE https://github.com/SpecterOps/bloodhound-enterprise/pull/1708

Motivation and Context

Resolves BED-9186

Why is this change required? What problem does it solve?

How Has This Been Tested?

validated schema updates in UI

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Summary by CodeRabbit

  • API Updates
    • Added a dedicated client support bundle schema with artifact identifiers, status, size, operation details, and lifecycle timestamps.
    • Clarified the distinction between support bundle records and client management operations.
    • Updated support bundle summaries and API references to use the revised schema definitions.
    • Refined management operation responses to focus on artifact, status, and lifecycle information.

@lrfalslev lrfalslev self-assigned this Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4f48507e-149f-42ce-ac65-7427e2359471

📥 Commits

Reviewing files that changed from the base of the PR and between e324e12 and 6eeeb9f.

📒 Files selected for processing (4)
  • packages/go/openapi/doc/openapi.json
  • packages/go/openapi/src/schemas/model.client-support-bundle-summary.yaml
  • packages/go/openapi/src/schemas/model.client-support-bundle.yaml
  • packages/javascript/js-client-library/src/responses.ts
💤 Files with no reviewable changes (1)
  • packages/javascript/js-client-library/src/responses.ts

📝 Walkthrough

Walkthrough

The OpenAPI contract now separates client support bundles from client management operations. Support-bundle references and artifact metadata were updated, and the JavaScript ManagementOperation type was aligned with the revised contract.

Changes

Support bundle and management operation contracts

Layer / File(s) Summary
Separate support-bundle and management-operation schemas
packages/go/openapi/src/schemas/model.client-support-bundle.yaml, packages/go/openapi/doc/openapi.json, packages/go/openapi/src/schemas/model.client-support-bundle-summary.yaml
The OpenAPI definitions separate support-bundle artifact fields from management-operation fields. The artifact-status enum and affected references were updated.
Align JavaScript management operation response
packages/javascript/js-client-library/src/responses.ts
ManagementOperation removes requester, creation-time, and execution-time fields while retaining operation lifecycle fields.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: api, documentation, javascript

Suggested reviewers: mykeelium

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: preventing large support bundle downloads under BED-9186.
Description check ✅ Passed The description includes the required sections, linked ticket, change rationale, testing note, change type, and completed checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lfalslev/bed-9186

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added api A pull request containing changes affecting the API code. documentation Improvements or additions to documentation javascript Pull requests that update javascript code labels Aug 10, 2026
@lrfalslev
lrfalslev merged commit 89e6d65 into main Aug 10, 2026
15 checks passed
@lrfalslev
lrfalslev deleted the lfalslev/bed-9186 branch August 10, 2026 15:49
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api A pull request containing changes affecting the API code. documentation Improvements or additions to documentation javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants