Use i32 for homological degree#186
Merged
JoeyBF merged 1 commit intoSpectralSequences:masterfrom Mar 7, 2025
Merged
Conversation
hoodmane
approved these changes
Mar 7, 2025
Contributor
hoodmane
left a comment
hoodmane
left a comment
There was a problem hiding this comment.
Nice also to see how many casts this removes.
Collaborator
Author
|
I also found it very satisfying! Also because many fields went from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables a few things.
Bidegrees to index full-page spectral sequences, like in thesseqsubcrate or the webserver.[i32; 2], to allow for generalizing to[i32; N]for multi-graded objects in the future.