Use bidegrees in sseq subcrate and webserver#188
Merged
JoeyBF merged 5 commits intoSpectralSequences:masterfrom Nov 13, 2025
Merged
Use bidegrees in sseq subcrate and webserver#188JoeyBF merged 5 commits intoSpectralSequences:masterfrom
sseq subcrate and webserver#188JoeyBF merged 5 commits intoSpectralSequences:masterfrom
Conversation
JoeyBF
force-pushed
the
bidegrees_everywhere
branch
2 times, most recently
from
e5246c8 to
beb2f5a
Compare
hoodmane
approved these changes
Nov 12, 2025
Contributor
hoodmane
left a comment
hoodmane
left a comment
There was a problem hiding this comment.
Generally looks good to me.
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
JoeyBF
force-pushed
the
bidegrees_everywhere
branch
from
0f73cdb to
98b2b2f
Compare
JoeyBF
force-pushed
the
bidegrees_everywhere
branch
from
98b2b2f to
cd9815b
Compare
github-actions bot
added a commit
that referenced
this pull request
Nov 13, 2025
* Use bidegrees in `sseq` crate and webserver * Update JS for bidegrees * Better JS style Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> * Adjust for new `Bidegree` internals * Apply 2024 rustfmt --------- Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
github-actions bot
added a commit
to JoeyBF/sseq
that referenced
this pull request
Nov 13, 2025
* Use bidegrees in `sseq` crate and webserver * Update JS for bidegrees * Better JS style Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> * Adjust for new `Bidegree` internals * Apply 2024 rustfmt --------- Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
github-actions bot
added a commit
to JoeyBF/sseq
that referenced
this pull request
Nov 17, 2025
* Use bidegrees in `sseq` crate and webserver * Update JS for bidegrees * Better JS style Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> * Adjust for new `Bidegree` internals * Apply 2024 rustfmt --------- Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the changes I discussed in the second bullet point of #186. Now all Rust code uses bidegrees, and the webserver JS does the packing/unpacking. This does not contain any change related to #187.
One improvement I see would be to have both immutable and mutable accessors on
sseq::Sseqfordifferentials,permanent_classes,page_data, andinvalid, that would take bidegrees as inputs and encapsulate the little[b.x()][b.y()]dance. I didn't do that for this PR to keep the code close to the original