Enable building libcommuni with QT6 - #545
Merged
Merged
Conversation
adds a CMAKE option to find QT6 libraries with libcommuni adds a #define to conditionally #include QtCore5Compat Signed-off-by: Bill Prendergast <dek.devel@baisenvar.info>
Use QT_VERSION & QT_VERSION_CHECK macros from <QtGlobal> (included via <QtCore>). This also enables being more selective about the version for the QString::SkipEmptyParts to Qt::SkipEmptyParts deprecation fixup Signed-off-by: Bill Prendergast <dek.devel@baisenvar.info>
vitalyster
requested changes
Jul 26, 2026
vitalyster
left a comment
vitalyster
left a comment
Collaborator
There was a problem hiding this comment.
Google says Qt::SkipEmptyParts is available since Qt 5.14, is it the only change? We can safely drop version check and use it, minimal Qt version is 5.15 for us.
Also it is not clear why Qt5Compat needed?
Contributor
Author
|
Qt5Compat is needed as QT6 removed <QTextCodec> and <QRegExp> (and others) which are used by libcommuni |
Collaborator
|
We using it or libcommuni used? If we not using then it is private libcommuni dependency and it should be linked in their build script, not in ours |
Contributor
Author
so yes we are using at least one of the Qt5Compat modules |
Collaborator
|
We can remove backports and use parseColors from libcommuni, is seems backports were required for some old libcommuni version, now we did not support these versions. |
- Removed libcommuni/backports.h and so no need for Core5Compat - as minimum supported QT version is 5.15 no need to test for greater than QT-5.14 in backends/libcommuni/session.cpp Signed-off-by: Bill Prendergast <dek.devel@baisenvar.info>
Signed-off-by: Bill Prendergast <dek.devel@baisenvar.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebase to master for Remove Swiften dependency from backend plugins
adds a CMAKE option to find and build with QT6 libraries with libcommuni
Closes #537