Move probeinterface.testing out of the API; fixes #321#322
Closed
musicinmybrain wants to merge 1 commit intoSpikeInterface:mainfrom
Closed
Move probeinterface.testing out of the API; fixes #321#322musicinmybrain wants to merge 1 commit intoSpikeInterface:mainfrom
musicinmybrain wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 89.58% 89.53% -0.05%
==========================================
Files 12 11 -1
Lines 1939 1930 -9
==========================================
- Hits 1737 1728 -9
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alejoe91
reviewed
Mar 7, 2025
| from probeinterface import read_3brain | ||
|
|
||
| from probeinterface.testing import validate_probe_dict | ||
| from ..utilities import validate_probe_dict |
Member
There was a problem hiding this comment.
Suggested change
| from ..utilities import validate_probe_dict | |
| from probeinterface.testing import validate_probe_dict |
@musicinmybrain can you elaborate on why it's not a good ide to include the validate_probe_dict in the API? I think it's an important function also for the package, so I would leave it there...
alejoe91
reviewed
Mar 7, 2025
| import jsonschema | ||
|
|
||
| json_schema_file = Path(__file__).absolute().parent.parent.parent / "resources" / "probe.json.schema" | ||
| json_schema_file = Path(__file__).absolute().parent.parent / "resources" / "probe.json.schema" |
Member
|
@musicinmybrain thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one idea for how to deal with #321.