-
Notifications
You must be signed in to change notification settings - Fork 47
Better handling of model_name in neuropixels probe to generate the neuropixels library #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 90.00% 90.07% +0.07%
==========================================
Files 12 12
Lines 2030 2036 +6
==========================================
+ Hits 1827 1834 +7
+ Misses 203 202 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
In the current version, the Open Ephys It would be better to have a |
alejoe91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use model_name_full, since name can be used as a "device" name to the probe. For example, Open Ephys names its probes ProbeA, B, etc
|
Not sure it is a good idea because model_name_full will an annoation and harder to discover than the simple "name" which part of the format. annations is somehow a free extension of fields. |
|
After some discussion, @samuelgarcia and I decided to keep the |
Better handling of model_name in neuropixels probe to generate the neuropixels library.
Now for instance:
model_name = "NP1010"end
name = "Neuropixels 1.0 NHP short staggered probe with cap"This is more consistent <with the probeinterface_library.
Also change IMEC to imec.
Also handle float for positions