Rename read_spikegadgets to read_spikegadgets_neuropixels and add has_spikegadgets_neuropixels_probes#440
Merged
Conversation
alejoe91
approved these changes
May 22, 2026
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436. The current
read_spikegadgetsname implies it reads any SpikeGadgets.recrecording, but it only handles Neuropixels probes: it filtersHardwareConfigurationonname == "NeuroPixels1"and silently ignores tetrodes and other probe types the headstage can record. This mirrors the misnomer that #427 corrected on the Open Ephys side, so I followed the same pattern: rename toread_spikegadgets_neuropixelsand keepread_spikegadgetsas aDeprecationWarningalias that forwards to it, so existing user code keeps working with no behavior change.I also added
has_spikegadgets_neuropixels_probes, equivalent tohas_neuropixels_probesfor Open Ephys. It parses the.recXML header and returnsTruewhen at least oneHardwareConfigurationDeviceentry has a Neuropixels source name.