Skip to content

Readd pykilosort test#50

Merged
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
chyumin:readd-pyks-test
Oct 7, 2022
Merged

Readd pykilosort test#50
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
chyumin:readd-pyks-test

Conversation

@chyumin
Copy link
Copy Markdown
Collaborator

@chyumin chyumin commented Aug 19, 2022

This PR should be merged only after SpikeInterface/spikeinterface#890

@bendichter
Copy link
Copy Markdown
Collaborator

['Warning! The recording is already filtered, but combinato filter is enabled\n', 'Traceback (most recent call last):\n File "/tmp/pytest-of-runner/pytest-0/test_combinato0/in_container_sorter_script.py", line 17, in \n sorting = run_sorter_local(\n File "/home/runner/.local/lib/python3.8/site-packages/spikeinterface/sorters/runsorter.py", line 161, in run_sorter_local\n SorterClass.setup_recording(recording, output_folder, verbose=verbose)\n File "/home/runner/.local/lib/python3.8/site-packages/spikeinterface/sorters/basesorter.py", line 196, in setup_recording\n cls._setup_recording(recording, output_folder, sorter_params, verbose)\n File "/home/runner/.local/lib/python3.8/site-packages/spikeinterface/sorters/combinato/combinato.py", line 138, in setup_recording\n write_to_h5_dataset_format(recording, dataset_path='/data', segment_index=0,\n File "/home/runner/.local/lib/python3.8/site-packages/spikeinterface/core/core_tools.py", line 560, in write_to_h5_dataset_format\n traces = recording.get_traces(segment_index=segment_index,\n File "/home/runner/.local/lib/python3.8/site-packages/spikeinterface/core/baserecording.py", line 144, in get_traces\n raise ValueError('This recording do not support return_scaled=True (need gain_to_uV and offset'\nValueError: This recording do not support return_scaled=True (need gain_to_uV and offset_to_uV properties)\n']

Is it possible to use return_scaled=False?

@chyumin
Copy link
Copy Markdown
Collaborator Author

chyumin commented Aug 25, 2022

@chyumin chyumin marked this pull request as draft August 25, 2022 21:50
@chyumin
Copy link
Copy Markdown
Collaborator Author

chyumin commented Aug 25, 2022

Converting this PR to draft because pykilosort test is still failing

@chyumin
Copy link
Copy Markdown
Collaborator Author

chyumin commented Sep 12, 2022

This PR should fix pykilosort test error.

@alejoe91 alejoe91 marked this pull request as ready for review October 7, 2022 17:32
@alejoe91 alejoe91 merged commit 664db73 into SpikeInterface:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants