Update WaveformView xrange using newly computed xvects #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
reviewed
Jun 16, 2025
| x_margin =50 | ||
| y_margin =150 | ||
| self._x_range = np.min(self.xvect) - x_margin , np.max(self.xvect) + x_margin | ||
| self._x_range = np.min(xvects) - x_margin , np.max(xvects) + x_margin |
Member
There was a problem hiding this comment.
probably the same issue is in panel as well. Can you test the web mode too?
Member
Author
There was a problem hiding this comment.
I can't get web mode working... will keep trying...
Member
Author
There was a problem hiding this comment.
It's me, hi, I'm the problem, it's me
Fixed now, and web updated
Member
|
merci |
alejoe91
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
On a multi-shank probe, the xRange on the
WaveformViewwasn't updating when I selected a new unit.I think I tracked down the problem:
self._x_rangeshould be computed using the newly computed xvect (higher up in the function) rather than the one stored inself.Alternative solution: the new
xvectsshould be stored inself??(don't ask me how this took 4 commits...)