Fix basescatterview binning and limits#235
Merged
chrishalcrow merged 5 commits intoSpikeInterface:mainfrom Feb 16, 2026
Merged
Conversation
Comment on lines
+319
to
+321
| margin = 0.2 * (np.max(ymaxs) - np.min(ymins)) | ||
| ymin = np.min(ymins) - margin | ||
| ymax = np.max(ymaxs) + margin |
Member
There was a problem hiding this comment.
I'm not a big fan of the margin - it makes the histogram and the scatter plot feel out of sync.
With margin:
Without margin:
Member
There was a problem hiding this comment.
I'd also be ok with computing and plotting the histogram for the full range, then setting the the y-range after to match the percentiles + margin.
Member
Author
There was a problem hiding this comment.
No I tried and it's awful with outliers eheheh! I can remove margins, or should we have it as a setting?
Member
Author
|
Margins removed @chrishalcrow |
chrishalcrow
approved these changes
Feb 16, 2026
Member
chrishalcrow
left a comment
chrishalcrow
left a comment
There was a problem hiding this comment.
Great. Think it improves the default view a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default binning strategy, for real data with non float amplitudes, you get a lot of zig-zags in the scatter histogram.
In addition, the default borders to compute histograms and limits are min/max of the data, with an hard-coded margin of 50.
This PR makes the limits and binning more adaptive by:
All in all it gives much better default limits for all scatters (amp scalings were super off with the 50 margin!)