Skip to content

KS4 test matrix is failing on Kilosort 4.1.1 – 4.1.6 (NumPy 2.0 incompatibility) #4589

@h-mayorquin

Description

@h-mayorquin

cc @JoeZiminski @alejoe91

The Testing Kilosort4 workflow iterates over every published Kilosort release on PyPI and runs the SpikeInterface integration tests against each one. Kilosort versions 4.1.1 through 4.1.6 were released in such a way that they are incompatible with the latest NumPy versions (MouseLand/Kilosort#1026), and that was only fixed in Kilosort 4.1.7.

The consequence is that every PR now picks up six pre-existing red checks that have nothing to do with the PR's diff. This has been broken on main itself since the Sunday cron run on 2026-04-19; five consecutive scheduled runs have failed without anyone catching it because cron-workflow failures don't surface on the main repo UI. The breakage is visible on my PR #4588 where 4.1.1 – 4.1.6 are red despite the diff not touching any sorter code; the workflow run is at actions/runs/26117618646 and the AttributeError: module 'numpy' has no attribute 'in1d' trace is visible in the 4.1.1 job at job/76810948024.

What should we do with these releases going forward? Kilosort 4.1.1 – 4.1.6 are functional on NumPy < 2.0 but will always fail on any environment with NumPy ≥ 2.0; 4.1.7 onward works on either. Honestly, if the promise is that we keep working with those old versions we kind of need to put a ceiling on numpy which does not seem feasible... what do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions