Add assert error in the case of unichannel data for sortingview backend + minor clarifications#2149
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Nov 2, 2023
Merged
Conversation
zm711
commented
Oct 31, 2023
| import pyvips | ||
| except ImportError: | ||
| raise ImportError("To use the timeseries in sorting view you need the pyvips package.") | ||
| raise ImportError("To use `plot_traces()` in sortingview you need the pyvips package.") |
Member
Author
There was a problem hiding this comment.
This is showing up as an unused import? Is this necessary somewhere else?
And should this be plot_traces with sortingview backend instead? I didn't want to change this one too much without confirmation first?
Member
There was a problem hiding this comment.
It is used internally by the sortingview backend. I'd leave it here.
Yes it should be plot_traces :)
Member
Author
There was a problem hiding this comment.
Cool thanks. I've only tested sortingview once, so other than Jeremy's talk (& yours) I didn't know too much about it.
alejoe91
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918,
I just put an assert to double check that each
tracesdoesn't have just one channel (though maybe >1 would be a better assert if my assumption of 0 not being possible is wrong). This should prevent the issue seen in #1918.Also tried to clarify a few errors asserts and added an assert comment for
clim.I think with this I'm done with super tiny PR fixes (for the moment :) ). I'll go back to working on module level assert touch-ups and do another pass of the docs after the release is done.