Fix template similarity when there are multiple sizes of units#2601
Merged
alejoe91 merged 2 commits intoMar 19, 2024
Merged
Conversation
zm711
reviewed
Mar 19, 2024
| else: | ||
| return _compute_template_similarity(waveform_extractor, waveform_extractor_other, method) | ||
| return _compute_template_similarity( | ||
| waveform_extractor=waveform_extractor, waveform_extractor_other=waveform_extractor_other, method=method |
Member
There was a problem hiding this comment.
Another win for keyword arguments :)
alejoe91
approved these changes
Mar 19, 2024
Member
|
Is it also done on the main branch ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixing issue #2599
And added a test to check that the agreement_scores are the expected size.