Add color_channels option in in plot_probe_map#2740
Merged
alejoe91 merged 12 commits intoSpikeInterface:mainfrom May 13, 2024
Merged
Add color_channels option in in plot_probe_map#2740alejoe91 merged 12 commits intoSpikeInterface:mainfrom
color_channels option in in plot_probe_map#2740alejoe91 merged 12 commits intoSpikeInterface:mainfrom
Conversation
Member
|
Thanks @RobertoDF, I think it's a good solution. Can you add a code example here and a screenshot to show how it looks? |
Contributor
Author
alejoe91
reviewed
Apr 22, 2024
Member
alejoe91
left a comment
There was a problem hiding this comment.
@RobertoDF one last suggestion. I think that instead of passing a list of one elements, one easier option is to allow this:
plot_probe_map(rec, color_channels="r")
See implementation details in review :)
Contributor
Author
|
definitely better 👍👍 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
for more information, see https://pre-commit.ci
color_channels option in in plot_probe_map
Member
|
@RobertoDF can you fix the conflict? Looks good to merge after that! |
Contributor
Author
|
ah yes, my mistake. hope it is ok now. |
alejoe91
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #2739