Check for SortingAnalyzer return_scaled in template_tools#2752
Merged
alejoe91 merged 3 commits intoSpikeInterface:mainfrom Apr 29, 2024
Merged
Check for SortingAnalyzer return_scaled in template_tools#2752alejoe91 merged 3 commits intoSpikeInterface:mainfrom
return_scaled in template_tools#2752alejoe91 merged 3 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
approved these changes
Apr 29, 2024
Member
|
Merci beaucoup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2751.
As the issue states there is a problem if the end-user sets the global
SortingAnalyzerreturn_scaled=Falsebecause in template tools it checks to make sure thatget_template_amplitudeshas the samereturn_scaledas theSortingAnalyzer. But the default isTruefor the function.In this PR we use the
SortingAnalyzer.return_scaledif it is a sorting analyzer andTrueif it isTemplateswhich was the previous default. We missed this becausereturn_scaled=Trueis the default for theSortingAnalyzerwhich wouldn't trigger this.