Fix KS4 for v>=4.0.5 and simplify skip correction#2774
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Apr 29, 2024
Merged
Fix KS4 for v>=4.0.5 and simplify skip correction#2774alejoe91 merged 2 commits intoSpikeInterface:mainfrom
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
changed the title
zm711
approved these changes
Apr 29, 2024
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
And I tested this locally both with and without drift correction ran fine on KS 4.0.6
Removal of parse maybe? But otherwise looks good to me.
| from pathlib import Path | ||
| import os | ||
| from typing import Union | ||
| from packaging.version import parse |
Member
There was a problem hiding this comment.
Where are we using parse? I don't see it in the diff. Maybe the original idea was to treat different versions differently?
Member
Author
There was a problem hiding this comment.
yep indeed that was the original idea, removing :)
| artifact_threshold=artifact, | ||
| file_object=file_object, | ||
| ) | ||
| ops["nblocks"] = 0 |
Member
There was a problem hiding this comment.
This is the KS based solution for skipping drift correction right?
I think it does make things simpler to just rely on their machinery. Maybe this will speed things up too from the wrapper?
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2742