Skip to content

improve verbose of ChunkRecordingExecutor #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 3 commits into from
May 13, 2024
Merged

improve verbose of ChunkRecordingExecutor #2795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f42a45
improve verbose of chunk recording executor
h-mayorquin May 2, 2024
570afda
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 2, 2024
c5ea9dd
Merge branch 'main' into improve_verbose_in_chunk_recording_executor
h-mayorquin May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/spikeinterface/core/job_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,27 @@ def __init__(
self.max_threads_per_process = max_threads_per_process

if verbose:
print(self.job_name, "with n_jobs =", self.n_jobs, "and chunk_size =", self.chunk_size)
if self.n_jobs > 1:
chunk_memory = self.chunk_size * recording.get_num_channels() * np.dtype(recording.get_dtype()).itemsize
total_memory = chunk_memory * self.n_jobs
chunk_duration = self.chunk_size / recording.get_sampling_frequency()
from spikeinterface.core.core_tools import convert_bytes_to_str, convert_seconds_to_str

chunk_memory_str = convert_bytes_to_str(chunk_memory)
total_memory_str = convert_bytes_to_str(total_memory)
chunk_duration_str = convert_seconds_to_str(chunk_duration)
print(
self.job_name,
"\n"
Copy link
Copy Markdown
Member

@samuelgarcia samuelgarcia May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure 2 lines is a good idea because with the progressbar this will be 3 lines in total.

Copy link
Copy Markdown
Collaborator Author

@h-mayorquin h-mayorquin May 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with reducing it to two. Any preferences @alejoe91 ?

Copy link
Copy Markdown
Collaborator Author

@h-mayorquin h-mayorquin May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to one line.

image

f"n_jobs={self.n_jobs} - "
f"samples_per_chunk={self.chunk_size:,} - "
f"chunk_memory={chunk_memory_str} - "
f"total_memory={total_memory_str} - "
f"chunk_duration={chunk_duration_str}",
)

else:
print(self.job_name, "with n_jobs =", self.n_jobs, "and chunk_size =", self.chunk_size)

def run(self):
"""
Expand Down