Channel aggregation preserves names#2797
Merged
alejoe91 merged 6 commits intoSpikeInterface:mainfrom May 14, 2024
Merged
Conversation
zm711
reviewed
May 3, 2024
alejoe91
changed the title
alejoe91
reviewed
May 13, 2024
alejoe91
reviewed
May 13, 2024
alejoe91
reviewed
May 13, 2024
alejoe91
reviewed
May 13, 2024
alejoe91
reviewed
May 13, 2024
alejoe91
approved these changes
May 14, 2024
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2789
This added a tests for what to do when the channels_ids are not unique or not shared type as discussed in the issue.
The only contentious issue is that it takes a stance on the issue #1432 by making the default strings.