Add extra check in fix_job_kwargs

[zm711]

For functions that take in an n_jobs argument they all run fix_job_kwargs, but if the user gives something like 4.0 to mean 4 jobs they end up with (if they have 4 cores)

int(4.0 * 4.0) = 16

So instead we should cast 4.0 -> 4 and just make it 4 jobs no?

What do you think @alejoe91 ?

[alejoe91]

Suggested change

	if isinstance(n_jobs, float):
	if isinstance(n_jobs, float) and n_jobs <= 1:

@zm711 maybe this is better?

[alejoe91]

we would need to add another:

else:
    n_jobs = int(n_jobs)

[zm711]

So flip the if-else so the more common path is triggered first?

if isinstance(n_jobs, float) and n_jobs <= 1:
    int(n_jobs * os.cpu_counts())
else:
    int(n_jobs)

[zm711]

I see you're saying fuse all into if-elif-else!

[zm711]

Let me know what you think of this!

[alejoe91]

Yep looks great!

[zm711]

I personally think that we should raise an error if someone sets 0 jobs rather than fix it for them....

Should I change that test or revert raising the error?

[alejoe91]

I personally think that we should raise an error if someone sets 0 jobs rather than fix it for them....

Should I change that test or revert raising the error?

The old behavior was to set n_jobs=1 if n_jobs=0, right? I agree that raising an error is better.
Maybe one wants to type 10 and misses the 1 ;)