Remove unused extractor attribute extractor_name#2874
Merged
alejoe91 merged 8 commits intoSpikeInterface:mainfrom Jul 3, 2024
Merged
Remove unused extractor attribute extractor_name#2874alejoe91 merged 8 commits intoSpikeInterface:mainfrom
extractor_name#2874alejoe91 merged 8 commits intoSpikeInterface:mainfrom
Conversation
h-mayorquin
added
extractors
Collaborator
Author
|
Requires #2876 for some reason : O |
samuelgarcia
approved these changes
Jul 3, 2024
samuelgarcia
approved these changes
Jul 3, 2024
Member
|
Merci. We can merge when tets pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this is within the context of the discussion in #2784
This is an unused attribute as far as my search skills in the repo point out. There is a mention to it ne neo utils but reading the function it actually does not use
extractor_nameit but uses thenameattribute:https://github.com/h-mayorquin/spikeinterface/blob/5d743469765f60ed5fbfaa819e45a5ae457d7722/src/spikeinterface/extractors/neoextractors/neo_utils.py#L6-L29
In general I think that there are some equivocations between
class.__name__and thenameattribute on the package. I did a small change in the repr to disambiguate this.