Skip to content

remove verbose from job_kwargs#2898

Merged
samuelgarcia merged 10 commits intoSpikeInterface:mainfrom
samuelgarcia:rem_verbose_from_job_kwargs
May 23, 2024
Merged

remove verbose from job_kwargs#2898
samuelgarcia merged 10 commits intoSpikeInterface:mainfrom
samuelgarcia:rem_verbose_from_job_kwargs

Conversation

@samuelgarcia
Copy link
Copy Markdown
Member

@samuelgarcia samuelgarcia commented May 23, 2024

Lets see what new bug this could trigger!

@h-mayorquin @zm711 : this has been discuss at many places.
Lets make a list of link here.

@samuelgarcia samuelgarcia marked this pull request as ready for review May 23, 2024 10:26
@alejoe91 alejoe91 added the core Changes to core module label May 23, 2024
@alejoe91
Copy link
Copy Markdown
Member

I agree with this. verbose shoudl have nothing to do with job_kwargs and we'll have a common and global way to set verbosity once we move move to logging

@zm711
Copy link
Copy Markdown
Member

zm711 commented May 23, 2024

Definitely agree too. The verbosity of a library should be separate from the parallelization.

I do love the tqdm (probably because my personal verbosity is always set to True :P) so looking forward to the work on the logger.

@samuelgarcia samuelgarcia merged commit 0df2536 into SpikeInterface:main May 23, 2024
@h-mayorquin
Copy link
Copy Markdown
Collaborator

Damn guys you went too quick with this. This does not solve the problem.

@samuelgarcia samuelgarcia deleted the rem_verbose_from_job_kwargs branch July 29, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants