Regularised the API from parent_recording to recording in zero_channel_pad#2923
Merged
alejoe91 merged 3 commits intoSpikeInterface:mainfrom Jun 1, 2024
Merged
Regularised the API from parent_recording to recording in zero_channel_pad#2923alejoe91 merged 3 commits intoSpikeInterface:mainfrom
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
added
refactor
Member
|
Sam and I discussed about making a breaking change by also switching the |
alejoe91
added
the
hackathon-24
alejoe91
approved these changes
Jun 1, 2024
Member
|
Thanks @AnujVader ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpikeInterface/SpikeInterface-Hackathon-Edinburgh-May24#6
Changed variable name from parent_recording to recording