API: switch has_scaled -> has_scaleable_traces#2924
Merged
samuelgarcia merged 3 commits intoSpikeInterface:mainfrom May 30, 2024
Merged
API: switch has_scaled -> has_scaleable_traces#2924samuelgarcia merged 3 commits intoSpikeInterface:mainfrom
has_scaled -> has_scaleable_traces#2924samuelgarcia merged 3 commits intoSpikeInterface:mainfrom
Conversation
zm711
commented
May 29, 2024
samuelgarcia
approved these changes
May 30, 2024
alejoe91
added
the
hackathon-24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for developer and end-user clarity.
has_scaledis not clear because what we really have is the ability to scale the traces so this object ishas_scaleable_traceswhich clearly states what the boolean is indicating.