Remove numba type signature to prevent compilation of numba functions at import#2932
Merged
h-mayorquin merged 2 commits intoSpikeInterface:mainfrom May 30, 2024
Merged
Conversation
zm711
changed the title
zm711
changed the title
zm711
changed the title
h-mayorquin
approved these changes
May 30, 2024
h-mayorquin
added
packaging
alejoe91
added
the
hackathon-24
h-mayorquin
added a commit
to h-mayorquin/spikeinterface
that referenced
this pull request
Jun 1, 2024
Co-authored-by: Heberto Mayorquin <h.mayorquin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://numba.discourse.group/t/reducing-import-time/1072/8
This discussion says that providing type signatures gives type checking, but then leads to eager compilation. This PR tests removing that to see if it speeds import time.