Skip to content

Make _set_probes private#2949

Merged
h-mayorquin merged 6 commits intoSpikeInterface:mainfrom
zm711:make-set-probes-private
Jun 5, 2024
Merged

Make _set_probes private#2949
h-mayorquin merged 6 commits intoSpikeInterface:mainfrom
zm711:make-set-probes-private

Conversation

@zm711
Copy link
Copy Markdown
Member

@zm711 zm711 commented May 31, 2024

Currently without a deprecation. Do we want a deprecation just to be safe for this one? Again it is not documented but someone could be using it...?

@zm711 zm711 added the core Changes to core module label May 31, 2024
@alejoe91 alejoe91 added the hackathon-24 Contributions during the SpikeInterface Hackathon May 24 label Jun 1, 2024
Copy link
Copy Markdown
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread src/spikeinterface/extractors/neoextractors/spikegadgets.py Outdated
Comment thread src/spikeinterface/core/baserecordingsnippets.py Outdated
@h-mayorquin h-mayorquin merged commit 8bbccab into SpikeInterface:main Jun 5, 2024
@zm711 zm711 deleted the make-set-probes-private branch April 25, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to core module hackathon-24 Contributions during the SpikeInterface Hackathon May 24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants