Patch for regularizing folder arguments#2968
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Jun 4, 2024
Merged
Conversation
Member
Author
|
Just noticed the issue. Let me get the last couple. Issue is I don't have docker so I didn't run those test. My bad! |
Contributor
Member
Author
|
Awesome thanks! |
alejoe91
approved these changes
Jun 4, 2024
Member
|
Grazie Zach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2967 , Fixes #2965.
A bug noticed by @NinelK.
If folder is None we should set folder to the output for docker/singularity.
To answer your question in the commit history Nina,
they can be strings because we are adding here then we switch to path. We could do the same with a Path, but it doesn't really matter.
Thanks for spotting the bug. related to #2917.--Needs to be tested by someone with Docker.