Skip to content

whiteningRange added as Kilosort 2.5 parameter#2997

Merged
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
Djoels:main
Jun 21, 2024
Merged

whiteningRange added as Kilosort 2.5 parameter#2997
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
Djoels:main

Conversation

@Djoels
Copy link
Copy Markdown

@Djoels Djoels commented Jun 7, 2024

previously this parameter was set to 32, by adding it to default parameters this can now be set to a different value.

@Djoels Djoels changed the title whiteningRange added as parameter whiteningRange added as Kilosort 2.5 parameter Jun 7, 2024
@alejoe91
Copy link
Copy Markdown
Member

alejoe91 commented Jun 7, 2024

Would it make sense to propagate to KS2 and KS3? Not sure if this is also an available params to KS4

@alejoe91 alejoe91 added the sorters Related to sorters module label Jun 7, 2024
@Djoels
Copy link
Copy Markdown
Author

Djoels commented Jun 7, 2024

Would it make sense to propagate to KS2 and KS3? Not sure if this is also an available params to KS4

yes, I just added another commit for KS2 and KS3, same parameter also exists for KS4 but was added already previously

@samuelgarcia samuelgarcia added this to the 0.101.0 milestone Jun 12, 2024
@zm711 zm711 linked an issue Jun 19, 2024 that may be closed by this pull request
@alejoe91 alejoe91 merged commit 8cf0346 into SpikeInterface:main Jun 21, 2024
@zm711 zm711 mentioned this pull request Jun 21, 2024
@alejoe91 alejoe91 mentioned this pull request Jun 21, 2024
9 tasks
alejoe91 added a commit to alejoe91/spikeinterface that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sorters Related to sorters module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

whiteningRange in external sorter Kilosort2_5

3 participants