add recording.time_slice like recording.frame_slice#3034
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Jun 19, 2024
Merged
add recording.time_slice like recording.frame_slice#3034alejoe91 merged 2 commits intoSpikeInterface:mainfrom
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
Conversation
Member
|
I don't really see another name. I think |
Member
|
I like |
Collaborator
Author
|
All right. Then the name as it is is good. |
samuelgarcia
approved these changes
Jun 19, 2024
alejoe91
approved these changes
Jun 19, 2024
Member
|
merci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many times when I use spikeinterface I wish had this facility. recording.time_slice() to avoid having to do the conversion myself. This PR adds the functionality and a test.
That said, I am not sure I really like name, any suggestions @zm711, @JoeZiminski?
I am thinking on discoverability.
I think that if the methods started by slice it would be nice to get the auto-completition to either complete it to time or frame but because they are not
Maybe there is a better name?