Fix intan kwargs#3054
Merged
h-mayorquin merged 3 commits intoSpikeInterface:mainfrom Jun 20, 2024
Merged
Conversation
samuelgarcia
approved these changes
Jun 20, 2024
Comment on lines
+59
to
+61
| neo_version = packaging.version.parse(neo.__version__) | ||
| if neo_version > packaging.version.parse("0.13.1"): | ||
| self._kwargs.update(dict(ignore_integrity_checks=ignore_integrity_checks)) |
Member
There was a problem hiding this comment.
This should be done in line 45 also no ?
Collaborator
Author
There was a problem hiding this comment.
It is already handled inside the mapping function:
spikeinterface/src/spikeinterface/extractors/neoextractors/intan.py
Lines 70 to 75 in 5ae3a24
Collaborator
Author
|
Tested for my own data with forkserve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ignore_integrity_checkskeyword that was added recently was not propagated to the kwargs. So running thing in parallel with a context other than fork was not working. This PR fixes it.This also indicates that there are some missing tests there if this behavior was missing. I will think on how to add a general test to see that al kwargs are catched in another PR.