Remove unit_params_range from generate.py#3121
Merged
alejoe91 merged 1 commit intoSpikeInterface:mainfrom Jul 3, 2024
Merged
Conversation
alejoe91
approved these changes
Jul 2, 2024
Member
|
Any chance this needs a deprecation? Or is this new enough that it can just be deleted without annoying users? |
Collaborator
Author
|
Good question, my impression is it is quite new and it is not widely used. Also, it was not connected to anything so if was used it wasn't doing anything. As such, I think either remove or raise an error if trying to use saying it doesn't do anything, use |
Member
|
Merci Joe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3077 by removing the unused
unit_params_rangeingenerate.py. This previously allowed the user to set the parameters for templates injected into synthetic recordings. However I think it was superceeded byunit_params. @samuelgarcia you were correct on #3077unit_paramscan take a tuple in which case it will use these as bounds to generate template parameters randomly. Sounit_paramsperforms the job ofunit_params_range.