Implement apply_merges_to_sorting()#3154
Merged
alejoe91 merged 6 commits intoSpikeInterface:mainfrom Jul 6, 2024
Merged
Conversation
alejoe91
approved these changes
Jul 5, 2024
Member
|
ok for me! Should we merge? |
Member
Author
|
I add the function in API.rst |
for more information, see https://pre-commit.ci
Member
Author
|
@alejoe91 ready on my side. |
alejoe91
approved these changes
Jul 6, 2024
alejoe91
added a commit
to yger/spikeinterface
that referenced
this pull request
Jul 6, 2024
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theses two PR need
apply_merges_to_sorting()but I was not happy with behavior and implementation.#3043
#2934
Here a new implementation of the same idea but normally faster.
@alejoe91
This should be merge before #3043 #2934