Implement a simple system to have backward compatibility for Analyzer extension

[samuelgarcia]

This simple system enabling to hack on load self.params and self.data when a new features are implemented in an analyzer extension that imply new parameters and new variable in data.

It was for instace the case for template similarity

[zm711]

Do we not need to set need_backward_compatibility_on_load for the similarity?

It seemed to work without that though it gave a different error.

[samuelgarcia]

oups

[zm711]

Here's what I don't understand. Now that we've added the need_backward_compatibility_on_load now it is going back to failing with the first error where it can't find the max_lag_ms. I need to read this a bit better why it worked when that line was missing, but isn't working now.

[zm711]

Since the most recent commit, nothing I do works. I tried going back in and just deleting need_backward so it was like your original commit. But now regardless of what I do it gives me the missing max_lag_ms error.

[zm711]

Here's the current bug in merge units

  File ~\Documents\GitHub\spikeinterface\src\spikeinterface\core\sortinganalyzer.py:939 in merge_units
    if len(units) < 2:

TypeError: object of type 'int' has no len()

[zm711]

I have to finish up a presentation at the moment, so I can test another round in the background, but I can't track down this bug. Just let me know when ready for another test :)

[zm711]

Never mind I put the list in as a list instead of list of list. Let me try again :)

[zm711]

Okay the merge code works from loading an analyzer from 08MAY24 :) !!

[alejoe91]

Okay the merge code works from loading an analyzer from 08MAY24 :) !!

For me it works for waveform extractor folders loaded as analyzers from last year :P

[samuelgarcia]

I hope you both have tried sigui for this dataset.

[zm711]

It has a probegroup. Has that been patched yet?

[yger]

Not sure the problem is fully solved. While I can load the analyzer you gave me @alejoe91 for testing the merging, when applying new functions recursively, I still have errors such as

nbefore = int(self.params["ms_before"] * self.sorting_analyzer.sampling_frequency
return nbefore

KeyError: 'ms_before'

[alejoe91]

@yger I know, will push a fix tomorrow!

[alejoe91]

@yger fixed! The templates were not an extensions so they required a fix before in the code

[zm711]

Just one tiny error comment.