Skip to content

Fix name of principal_components ext in qm docs (take 2)#3261

Merged
alejoe91 merged 1 commit intoSpikeInterface:mainfrom
jonahpearl:pca_doc_fix
Jul 29, 2024
Merged

Fix name of principal_components ext in qm docs (take 2)#3261
alejoe91 merged 1 commit intoSpikeInterface:mainfrom
jonahpearl:pca_doc_fix

Conversation

@jonahpearl
Copy link
Copy Markdown
Contributor

@jonahpearl jonahpearl commented Jul 26, 2024

Fixes #3257

@zm711 zm711 added the documentation Improvements or additions to documentation label Jul 26, 2024
Copy link
Copy Markdown
Member

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonahpearl,

@samuelgarcia may merge it today otherwise @alejoe91 will merge it next week :)

EDIT: One other note @jonahpearl: I changed the text of your message. If you say Fixes xxx instead of the way you wrote it, then it will automatically close the issue when the PR is merged (just as an FYI).

@alejoe91 alejoe91 changed the title fix name of principal_components ext in qm docs (take 2) Fix name of principal_components ext in qm docs (take 2) Jul 29, 2024
@alejoe91 alejoe91 merged commit df76f94 into SpikeInterface:main Jul 29, 2024
@jonahpearl jonahpearl deleted the pca_doc_fix branch August 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SortingAnalyzer extension names "pca" vs "principal_components"

3 participants