Skip to content

Added sphinxcontrib-jquery#3307

Merged
samuelgarcia merged 2 commits intoSpikeInterface:mainfrom
tabedzki:updating_docs
Aug 28, 2024
Merged

Added sphinxcontrib-jquery#3307
samuelgarcia merged 2 commits intoSpikeInterface:mainfrom
tabedzki:updating_docs

Conversation

@tabedzki
Copy link
Copy Markdown
Contributor

…query

Fixes #3306 issue of missing the sphinxcontrib.jquery to the pyproject.toml.

Still needs to address other components of that issue.

@zm711
Copy link
Copy Markdown
Member

zm711 commented Aug 15, 2024

@JoeZiminski
@chrishalcrow

This was something you guys discussed no?

@zm711 zm711 added the documentation Improvements or additions to documentation label Aug 15, 2024
@chrishalcrow
Copy link
Copy Markdown
Member

Hello,
Yes, this package was added recently #2962 as it is no longer bundled with Sphinx. It's needed for the search engine. I didn't think to add to it pyproject.toml as it installed on my system: sphinxcontrib.jquery is a dependency of sphinx_rtd_theme so should install automatically. But it only become a dependency in sphinx_rtd_theme v1.2 (released a year ago). So, seems reasonable to include it as a docs dependency.

@tabedzki
Copy link
Copy Markdown
Contributor Author

@zm711 and @chrishalcrow
Ready for review. I added the minimum version of sphinx-rtd-theme and also included an explicit dependency on sphinxcontrib-jquery.

@zm711
Copy link
Copy Markdown
Member

zm711 commented Aug 16, 2024

This is good by me. @alejoe91 and @samuelgarcia handle all the merging so we will wait for them to merge :)

@alejoe91 alejoe91 added this to the 0.101.1 milestone Aug 27, 2024
@samuelgarcia
Copy link
Copy Markdown
Member

Merci.

@samuelgarcia samuelgarcia merged commit 24edb69 into SpikeInterface:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors compiling documentation locally

5 participants