nodepipeline : skip chunks when no peaks inside and skip_after_n_peaks#3356
Conversation
There was a problem hiding this comment.
Any chance we could start getting rudimentary docstrings? I've had to search through this to find a bug before and it was pretty painful. If we can start documenting a bit of the thought processes it will help us help people on the issue tracker :)
We can always edit them to make them tidy later. I'm really just asking for one liners for these functions.
|
pre-commit? :) |
…node_pipeline_skip_no_peaks
samuelgarcia
changed the title
|
@zm711 : I push some doc tell if you want more |
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Sam this is great. I really appreciate the work on this. :) Merci beaucoup.
| job_kwargs, | ||
| job_name="pipeline", | ||
| mp_context=None, | ||
| #mp_context=None, |
There was a problem hiding this comment.
Shouldn't we leave this for people that use positional?
There was a problem hiding this comment.
I think it was a mistake because it should be in job_kwargs no ?
Alessio is it you that add this mp_context directly here ?
|
|
||
| This usefull in several use cases: | ||
| * in sortingcomponents : detect peaks and make some computation on then (localize, pca, ...) | ||
| * in sortingcomponents : replay some peaks and make some computation on then (localize, pca, ...) |
There was a problem hiding this comment.
It is like a replay of spikes by buffer. Maybe another term would be better I found this image more easy.
There was a problem hiding this comment.
Unless this is extremely technical I don't think we could quite say this. It sounds more like you are pulling some sound engineering terminology into the spike world. Like you're remixing your data analysis. I think I get the vibe, but I'm not sure of a better word. We can leave it for now and if I think of something I can put in a PR patch later.
| Here a "peak" is a spike without any labels just a "detected". | ||
| Here a "spike" is a spike with any a label so already sorted. |
There was a problem hiding this comment.
I think this is super helpful. Nice comment!
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
4 participants
As in title
@yger : this is a revival of #2011 but with new gather and avoid double searchsorted