"quality" property to be read as string instead of object in BasePhyKilosortSortingExtractor#3365
Merged
alejoe91 merged 1 commit intoSpikeInterface:mainfrom Sep 5, 2024
Conversation
Member
|
Thanks @h-mayorquin Let's merge this for now, but I like the |
alejoe91
approved these changes
Sep 5, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, this specific column which we know is a string is unnecessarily read as an object.
This is a simple patch so this property is converted as a string.
Another possible more general solution is to use this function from pandas after reading the cluster info data frames and merging
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.convert_dtypes.html
I think this could simplify the logic here where we do the casting:
https://github.com/h-mayorquin/spikeinterface/blob/5953d6cdaac993928988a715725b824edf11d00a/src/spikeinterface/extractors/phykilosortextractors.py#L167-L183
@pauladkisson