Fix metrics widgets for convert_dtypes#3417
Merged
alejoe91 merged 1 commit intoSpikeInterface:mainfrom Sep 16, 2024
Merged
Conversation
Member
Author
|
@zm711 if you could approve this I'll go ahead wiht the review! |
zm711
reviewed
Sep 16, 2024
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
One tiny question. Should we unify that someway? Why return None sometimes and np.nan other times. It might work better long-term if we can have consistent behavior?
Member
Author
I think with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some bug fixes out of #3370 for better logging :)