Add verbose kwarg to mda write_recording#3535
Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom Nov 19, 2024
Merged
Conversation
zm711
reviewed
Nov 13, 2024
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Looks good to me, let's see what happens when you the user tests it :)
Member
Author
|
This has fixed (the first) problem in issue #3532 : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #3532
Adds
verboseas a kwarg towrite_recordingforMdaRecordingExtractorclass, rather then it being injob_kwargs.Probably missed when we removed
verbosefromjob_kwargs. Does this look like a reasonable fix @zm711 ? This seems like a good time to check all theRecordingExtractors.