Add how to make a release notes#3793
Merged
alejoe91 merged 13 commits intoSpikeInterface:mainfrom Apr 17, 2025
Merged
Conversation
zm711
reviewed
Mar 21, 2025
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Member
chrishalcrow
left a comment
chrishalcrow
left a comment
There was a problem hiding this comment.
Yeah - a great idea! Just some little bits and pieces.
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
zm711
reviewed
Apr 1, 2025
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
I think this is about ready for final review Heberto. But I guess there is no rush on it if you were thinking of something else :)
| Checklist | ||
| ^^^^^^^^^ | ||
| * pyproject.toml: check that the version is ahead of current release. Also, comment out the @ (git dependencies) | ||
| * In the top level ``__init__`` (located on ``src/spikeinterface/__init__.py``) uncomment ``DEV_MODE`` (this is used for the docker installations) |
Member
There was a problem hiding this comment.
Suggested change
| * In the top level ``__init__`` (located on ``src/spikeinterface/__init__.py``) uncomment ``DEV_MODE`` (this is used for the docker installations) | |
| * In the top level ``__init__`` (located on ``src/spikeinterface/__init__.py``) uncomment ``DEV_MODE`` (this is used for the docker installations) |
The dev_mode is completely clear because we have the two lines one with True and one with False. To be clear we should say to uncomment the DEV_MODE=False and to comment out the DEV_MODE=True
Collaborator
Author
There was a problem hiding this comment.
improved by Alessio somewhere down this thread.
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Collaborator
Author
There is a release to be doing soon. I want to shadow @alejoe91 during it and after I will add more notes here. |
Member
|
Sounds good to me! |
alejoe91
reviewed
Apr 2, 2025
h-mayorquin
commented
Apr 2, 2025
h-mayorquin
commented
Apr 2, 2025
alejoe91
reviewed
Apr 17, 2025
alejoe91
reviewed
Apr 17, 2025
alejoe91
approved these changes
Apr 17, 2025
Member
|
Thanks @h-mayorquin LGTM! Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft