BUG FIX: ensure matching of args in aggregate_channels and ChannelAggregationRecording #3829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3825.
In #3767, we decided to deprecate
recording_listin favor orrecording_list_or_dict, now thataggregate_channelscan accept dicts. I did the deprecation at the "user level" by putting it inaggregate_channelsand only allowingChannelAggregationRecordingto acceptrecording_list_or_dict. This creates a bug since the saving functions use the args fromaggregate_channelsbut the load-from-provenance functions use the args fromChannelAggregationRecording. So e.g. sorting fails in #3825.This PR fixes the bug by unifying the arguments in the function and class.
Minimal version of #3825 bug: